Hi Andy,
On Tue, Mar 12, 2019 at 2:18 PM Andy Shevchenko
<[email protected]> wrote:
> We have to free on ->remove() the allocated resources on ->probe().
>
> Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support")
> Cc: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Andy Shevchenko <[email protected]>
Thanks, nice catch!
> --- a/drivers/auxdisplay/hd44780.c
> +++ b/drivers/auxdisplay/hd44780.c
> @@ -280,6 +280,8 @@ static int hd44780_remove(struct platform_device *pdev)
> struct charlcd *lcd = platform_get_drvdata(pdev);
>
> charlcd_unregister(lcd);
> +
> + kfree(lcd);
(wearing a newer (and hopefully wiser ;-) hat than when I wrote the code)
While this is correct for the current implementation of struct charlcd_priv,
this may be a bit fragile.
What about adding a charlcd_free() wrapper, which can do kfree(to_priv(lcd)),
and be used in the probe failure path, too?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
