Re: [PATCH V3 06/10] mmc: cqhci: allow hosts to update dcmd cmd desc

[Ritesh Harjani]

On 3/14/2019 3:15 AM, Sowjanya Komatineni wrote:

This patch adds update_dcmd_desc interface to cqhci_host_ops to
allow hosts to update any of the DCMD task descriptor attributes
and parameters.

Tested-by: Jon Hunter <jonath...@nvidia.com>
Signed-off-by: Sowjanya Komatineni <skomatin...@nvidia.com>

Thanks,

Reviewed-by: Ritesh Harjani <rite...@codeaurora.org>

---
  drivers/mmc/host/cqhci.c | 2 ++
  drivers/mmc/host/cqhci.h | 2 ++
  2 files changed, 4 insertions(+)

diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
index a8af682a9182..d59cb0a51964 100644
--- a/drivers/mmc/host/cqhci.c
+++ b/drivers/mmc/host/cqhci.c
@@ -537,6 +537,8 @@ static void cqhci_prep_dcmd_desc(struct mmc_host *mmc,
                 CQHCI_ACT(0x5) |
                 CQHCI_CMD_INDEX(mrq->cmd->opcode) |
                 CQHCI_CMD_TIMING(timing) | CQHCI_RESP_TYPE(resp_type));
+       if (cq_host->ops->update_dcmd_desc)
+               cq_host->ops->update_dcmd_desc(mmc, mrq, &data);
        *task_desc |= data;
        desc = (u8 *)task_desc;
        pr_debug("%s: cqhci: dcmd: cmd: %d timing: %d resp: %d\n",
diff --git a/drivers/mmc/host/cqhci.h b/drivers/mmc/host/cqhci.h
index 9e68286a07b4..8c8ec6f01c45 100644
--- a/drivers/mmc/host/cqhci.h
+++ b/drivers/mmc/host/cqhci.h
@@ -210,6 +210,8 @@ struct cqhci_host_ops {
        u32 (*read_l)(struct cqhci_host *host, int reg);
        void (*enable)(struct mmc_host *mmc);
        void (*disable)(struct mmc_host *mmc, bool recovery);
+       void (*update_dcmd_desc)(struct mmc_host *mmc, struct mmc_request *mrq,
+                                u64 *data);
  };

static inline void cqhci_writel(struct cqhci_host *host, u32 val, int reg)