Hi Arnd, On 07.03.19 12:33, Arnd Bergmann wrote: > clang warns about a tentative array definition in the gpio-omap driver: > > drivers/gpio/gpio-omap.c:1282:34: error: tentative array definition assumed > to have one element [-Werror] > static const struct of_device_id omap_gpio_match[]; > > It's best to just reorder the entire file to avoid forward declarations, > which lets us use the regular declaration. To do this, the unnecessary > CONFIG_OF check must also be removed. > > Signed-off-by: Arnd Bergmann <[email protected]> > --- > drivers/gpio/gpio-omap.c | 549 +++++++++++++++++++-------------------- > 1 file changed, 267 insertions(+), 282 deletions(-)
Sry, for delayed reply I do not have objection to the patch itself, so Reviewed-by: Grygorii Strashko <[email protected]> but personally i do not like such changes as they kill "git blame" :(, I assume there would be merge conflict with https://lkml.org/lkml/2019/3/11/945 -- Best regards, grygorii
