On 14/03/2019 15.24, Jacek Anaszewski wrote:
> Rasmus,
>
> Thank you for the update.
> Still, there is one thing to improve.
>
>> static int netdev_trig_activate(struct led_classdev *led_cdev)
>> {
>> struct led_netdev_data *trigger_data;
>> @@ -423,6 +451,8 @@ static int netdev_trig_activate(struct
>> led_classdev *led_cdev)
>> trigger_data->mode = 0;
>> atomic_set(&trigger_data->interval, msecs_to_jiffies(50));
>> trigger_data->last_activity = 0;
>> + if (led_cdev->flags & LED_INIT_DEFAULT_TRIGGER)
>> + netdev_trig_of_init(led_cdev, trigger_data);
>
> We don't necessarily want OF settings to be used for initialization on
> each LED trigger activation for the LED class device, but only on the
> first one. That's why the triggers using this flags clean it here:
>
> led_cdev->flags &= ~LED_INIT_DEFAULT_TRIGGER;
Right, I noticed that pattern, but wondered about it. If this is
supposed to be a general thing, why isn't it just done by the trigger
core after the call of led_trigger_set() in the two places the bit gets
set? I.e.
led_cdev->flags |= LED_INIT_DEFAULT_TRIGGER;
led_trigger_set(led_cdev, trig);
+ led_cdev->flags &= ~LED_INIT_DEFAULT_TRIGGER;
I can certainly add clearing the flag to my code, just wondering.
Rasmus
