On Tue, Mar 05, 2019 at 07:33:54PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-exynos/firmware.c:201:2-8: ERROR: missing of_node_put; > acquired a node pointer with refcount incremented on line 193, but without a > corresponding object release within this function. > ./arch/arm/mach-exynos/firmware.c:204:1-7: ERROR: missing of_node_put; > acquired a node pointer with refcount incremented on line 193, but without a > corresponding object release within this function. > ./arch/arm/mach-exynos/suspend.c:642:2-8: ERROR: missing of_node_put; > acquired a node pointer with refcount incremented on line 634, but without a > corresponding object release within this function. > > Signed-off-by: Wen Yang <[email protected]> > Reviewed-by: Florian Fainelli <[email protected]> > Cc: Russell King <[email protected]> > Cc: Kukjin Kim <[email protected]> > Cc: Krzysztof Kozlowski <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > ---
Thanks, applied, with adjustments in commit msg and removal of Florian's reviewed-by tag (I cannot find his email with review). Best regards, Krzysztof
