> -----Original Message----- > From: [email protected] <[email protected]> On > Behalf Of Borislav Petkov > Sent: Saturday, March 23, 2019 7:16 AM > To: Ghannam, Yazen <[email protected]> > Cc: [email protected]; [email protected] > Subject: Re: [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory > Controllers > > On Thu, Feb 28, 2019 at 03:36:10PM +0000, Ghannam, Yazen wrote: > > diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h > > index de8dbb0b42b5..40e63cea2d81 100644 > > --- a/drivers/edac/amd64_edac.h > > +++ b/drivers/edac/amd64_edac.h > > @@ -274,7 +274,11 @@ > > > > #define UMC_SDP_INIT BIT(31) > > > > -#define NUM_UMCS 2 > > +/* > > + * Number of Unified Memory Controllers > > + * Set during driver init based on family/model. > > + */ > > +static u8 num_umcs; > > Please don't do silly things like that: > > In file included from drivers/edac/amd64_edac_inj.c:2:0: > drivers/edac/amd64_edac.h:279:11: warning: ‘num_umcs’ defined but not used > [-Wunused-variable] > static u8 num_umcs; > ^~~~~~~~ > > I fixed it up now. >
Thanks. Sorry I missed that. -Yazen
