On 25/03/2019 12:31, Harish Bandi wrote:
> +bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type)
> +{
> + if ((soc_type == QCA_WCN3990) || (soc_type == QCA_WCN3998))
^ ^
spurious white-space here as well
> + return true;
> +
> + return false;
> +}
(Apologies for the bike-shed)
I don't know what the kernel coding-style says about this, but for
functions returning bool, isn't it better to write
return $BOOLEAN_EXPRESSION;
instead of
if ($BOOLEAN_EXPRESSION)
return true;
return false;
i.e.
bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type)
{
return soc_type == QCA_WCN3990 || soc_type == QCA_WCN3998;
}
Regards.
