On Mon, 25 Mar 2019 20:37:23 +0900
Namhyung Kim <[email protected]> wrote:
> > /* Called after a '!' character but "!=" and "!~" are not "not"s */
> > static bool is_not(const char *str)
> > @@ -947,8 +948,10 @@ static void append_filter_err(struct
> > filter_parse_error *pe,
> > if (pe->lasterr > 0) {
> > trace_seq_printf(s, "\n%*s", pos, "^");
> > trace_seq_printf(s, "\nparse_error: %s\n",
> > err_text[pe->lasterr]);
> > + tracing_log_err("event filter parse error",
> > filter->filter_string, err_text, pe->lasterr, pe->lasterr_pos);
> > } else {
> > trace_seq_printf(s, "\nError: (%d)\n", pe->lasterr);
> > + tracing_log_err("event filter parse error",
> > filter->filter_string, err_text, FILT_ERR_ERRNO, 0);
>
> These lines are too long, could you please wrap?
Agreed.
> Otherwise, the whole series look good to me.
>
> Acked-by: Namhyung Kim <[email protected]>
Thanks Namhyung!
-- Steve
