On Fri, Mar 22, 2019 at 05:59:17PM +0200, Jarkko Sakkinen wrote: > On Fri, Mar 22, 2019 at 07:38:58AM -0700, Tadeusz Struk wrote: > > The poll condition should only check response_length, > > because reads should only be issued if there is data to read. > > The response_read flag only prevents double writes. > > The problem was that the write set the response_read to false, > > enqued a tpm job, and returned. Then application called poll > > which checked the response_read flag and returned EPOLLIN. > > Then the application called read, but got nothing. > > After all that the async_work kicked in. > > Added also mutex_lock around the poll check to prevent > > other possible race conditions. > > > > Cc: [email protected] > > Fixes: 9488585b21bef0df12 ("tpm: add support for partial reads") > > Reported-by: Mantas Mikulėnas <[email protected]> > > Tested-by: Mantas Mikulėnas <[email protected]> > > Signed-off-by: Tadeusz Struk <[email protected]> > > Reviewed-by: Jarkko Sakkinen <[email protected]>
It is still missing the comment I asked to add. Otherwise, it is good. /Jarkko
