> Hi,
> Replacing kmalloc with kzalloc and cleaning up memset in
> arch/i386/kernel/io_apic.c
>
>
> Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]>
> ---
>
> diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c
> index 4b8a8da..1329615 100644
> --- a/arch/i386/kernel/io_apic.c
> +++ b/arch/i386/kernel/io_apic.c
> @@ -690,14 +690,12 @@ static int __init balanced_irq_init(void)
> physical_balance = 1;
>
> for_each_online_cpu(i) {
> - irq_cpu_data[i].irq_delta = kmalloc(sizeof(unsigned long) *
> NR_IRQS,
> GFP_KERNEL); - irq_cpu_data[i].last_irq =
> kmalloc(sizeof(unsigned long) *
> NR_IRQS, GFP_KERNEL); + irq_cpu_data[i].irq_delta =
> kzalloc(sizeof(unsigned long) * NR_IRQS, GFP_KERNEL);
> + irq_cpu_data[i].last_irq = kzalloc(sizeof(unsigned long) *
> NR_IRQS,
> GFP_KERNEL); if (irq_cpu_data[i].irq_delta == NULL ||
> irq_cpu_data[i].last_irq == NULL) { printk(KERN_ERR "balanced_irq_init: out
> of memory");
> goto failed;
> }
> - memset(irq_cpu_data[i].irq_delta,0,sizeof(unsigned long) *
> NR_IRQS);
> - memset(irq_cpu_data[i].last_irq,0,sizeof(unsigned long) *
> NR_IRQS);
> }
>
> printk(KERN_INFO "Starting balanced_irq\n");
How about using kcalloc here?
i.e.
...
... = kcalloc(NR_IRQS, sizeof(unsigned long), GFP_KERNEL);
...
Regards,
Mariusz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
