Re: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code

[Mukesh Ojha]

On 4/1/2019 11:51 AM, Anson Huang wrote:

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <anson.hu...@nxp.com>

Reviewed-by: Mukesh Ojha <mo...@codeaurora.org>

Cheers,
-Mukesh

---
  drivers/irqchip/irq-imx-irqsteer.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-imx-irqsteer.c 
b/drivers/irqchip/irq-imx-irqsteer.c
index 88df3d00..290531e 100644
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
  {
        struct device_node *np = pdev->dev.of_node;
        struct irqsteer_data *data;
-       struct resource *res;
        u32 irqs_num;
        int i, ret;

@@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct platform_device *pdev)

        if (!data)
                return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

-       data->regs = devm_ioremap_resource(&pdev->dev, res);
+       data->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(data->regs)) {
                dev_err(&pdev->dev, "failed to initialize reg\n");
                return PTR_ERR(data->regs);