Re: [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code

[Mukesh Ojha]

On 4/1/2019 11:37 AM, Anson Huang wrote:

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <anson.hu...@nxp.com>

Reviewed-by: Mukesh Ojha <mo...@codeaurora.org>

Cheers,
-Mukesh

---
  drivers/soc/imx/gpc.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
index 7d14a4b..a8f1e47 100644
--- a/drivers/soc/imx/gpc.c
+++ b/drivers/soc/imx/gpc.c
@@ -406,7 +406,6 @@ static int imx_gpc_probe(struct platform_device *pdev)
        const struct imx_gpc_dt_data *of_id_data = of_id->data;
        struct device_node *pgc_node;
        struct regmap *regmap;
-       struct resource *res;
        void __iomem *base;
        int ret;

@@ -417,8 +416,7 @@ static int imx_gpc_probe(struct platform_device *pdev)

            !pgc_node)
                return 0;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

-       base = devm_ioremap_resource(&pdev->dev, res);
+       base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(base))
                return PTR_ERR(base);