Re: [PATCH] watchdog: imx2_wdt: use devm_platform_ioremap_resource() to simplify code

[Mukesh Ojha]

On 4/1/2019 10:34 AM, Anson Huang wrote:

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <anson.hu...@nxp.com>

Reviewed-by: Mukesh Ojha <mo...@codeaurora.org>

Cheers,
-Mukesh

---
  drivers/watchdog/imx2_wdt.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
index 2b52514..1b0faa2 100644
--- a/drivers/watchdog/imx2_wdt.c
+++ b/drivers/watchdog/imx2_wdt.c
@@ -247,7 +247,6 @@ static int __init imx2_wdt_probe(struct platform_device 
*pdev)
  {
        struct imx2_wdt_device *wdev;
        struct watchdog_device *wdog;
-       struct resource *res;
        void __iomem *base;
        int ret;
        u32 val;
@@ -256,8 +255,7 @@ static int __init imx2_wdt_probe(struct platform_device 
*pdev)
        if (!wdev)
                return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

-       base = devm_ioremap_resource(&pdev->dev, res);
+       base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(base))
                return PTR_ERR(base);