On Mon, Apr 01, 2019 at 11:27:25AM +0200, Rafael J. Wysocki wrote: > On Thursday, March 28, 2019 11:33:21 AM CEST Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <[email protected]> > > > > There is not reason for the minimum iowait boost value in the > > schedutil cpufreq governor to depend on the available range of CPU > > frequencies. In fact, that dependency is generally confusing, > > because it causes the iowait boost to behave somewhat differently > > on CPUs with the same maximum frequency and different minimum > > frequencies, for example. > > > > For this reason, replace the min field in struct sugov_cpu > > with a constant and choose its values to be 1/8 of > > SCHED_CAPACITY_SCALE (for consistency with the intel_pstate > > driver's internal governor). > > > > [Note that policy->cpuinfo.max_freq will not be a constant any more > > after a subsequent change, so this change is depended on by it.] > > > > Link: > > https://lore.kernel.org/lkml/[email protected]/T/#ee20bdc98b7d89f6110c0d00e5c3ee8c2ced93c3d > > Suggested-by: Peter Zijlstra <[email protected]> > > Signed-off-by: Rafael J. Wysocki <[email protected]>
> Any more comments on this patch? I obviously like it :-) Acked-by: Peter Zijlstra (Intel) <[email protected]> > If not, I'll queue it up along with the rest of the series. Thanks!
