Commit-ID: 8f9affdf4094bde418a0dbd8b52bb503ee486469 Gitweb: https://git.kernel.org/tip/8f9affdf4094bde418a0dbd8b52bb503ee486469 Author: Joel Fernandes (Google) <j...@joelfernandes.org> AuthorDate: Wed, 20 Mar 2019 20:34:23 -0400 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Wed, 3 Apr 2019 09:51:01 +0200
sched/cpufreq: Annotate cpufreq_update_util_data pointer with __rcu Recently I added an RCU annotation check to rcu_assign_pointer(). All pointers assigned to RCU protected data are to be annotated with __rcu inorder to be able to use rcu_assign_pointer() similar to checks in other RCU APIs. This resulted in a sparse error: kernel//sched/cpufreq.c:41:9: sparse: error: incompatible types in comparison expression (different address spaces) Fix this by annotating cpufreq_update_util_data pointer with __rcu. This will also help sparse catch any future RCU misuage bugs. Signed-off-by: Joel Fernandes (Google) <j...@joelfernandes.org> [ From an RCU perspective. ] Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org> Reviewed-by: Paul E. McKenney <paul...@linux.ibm.com> Cc: Josh Triplett <j...@joshtriplett.org> Cc: Lai Jiangshan <jiangshan...@gmail.com> Cc: Linus Torvalds <torva...@linux-foundation.org> Cc: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> Cc: Mathieu Desnoyers <mathieu.desnoy...@efficios.com> Cc: Mike Galbraith <efa...@gmx.de> Cc: Morten Rasmussen <morten.rasmus...@arm.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Steven Rostedt <rost...@goodmis.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: keesc...@chromium.org Cc: kernel-harden...@lists.openwall.com Cc: kernel-t...@android.com Link: https://lkml.kernel.org/r/20190321003426.160260-2-j...@joelfernandes.org Signed-off-by: Ingo Molnar <mi...@kernel.org> --- kernel/sched/cpufreq.c | 2 +- kernel/sched/sched.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/cpufreq.c b/kernel/sched/cpufreq.c index 835671f0f917..b5dcd1d83c7f 100644 --- a/kernel/sched/cpufreq.c +++ b/kernel/sched/cpufreq.c @@ -7,7 +7,7 @@ */ #include "sched.h" -DEFINE_PER_CPU(struct update_util_data *, cpufreq_update_util_data); +DEFINE_PER_CPU(struct update_util_data __rcu *, cpufreq_update_util_data); /** * cpufreq_add_update_util_hook - Populate the CPU's update_util_data pointer. diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index efa686eeff26..713715dd00cf 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2185,7 +2185,7 @@ static inline u64 irq_time_read(int cpu) #endif /* CONFIG_IRQ_TIME_ACCOUNTING */ #ifdef CONFIG_CPU_FREQ -DECLARE_PER_CPU(struct update_util_data *, cpufreq_update_util_data); +DECLARE_PER_CPU(struct update_util_data __rcu *, cpufreq_update_util_data); /** * cpufreq_update_util - Take a note about CPU utilization changes.
