4.9-stable review patch.  If anyone has any objections, please let me know.

------------------

[ Upstream commit 62461ac2e5b6520b6d65fc6d7d7b4b8df4b848d8 ]

The percpu member of this structure is declared as:
        struct ... ** __percpu member;
So its type is:
        __percpu pointer to pointer to struct ...

But looking at how it's used, its type should be:
        pointer to __percpu pointer to struct ...
and it should thus be declared as:
        struct ... * __percpu *member;

So fix the placement of '__percpu' in the definition of this
structures.

This silents a few Sparse's warnings like:
        warning: incorrect type in initializer (different address spaces)
          expected void const [noderef] <asn:3> *__vpp_verify
          got struct sched_domain **

Link: 
http://lkml.kernel.org/r/20190118144902.79065-1-luc.vanoostenr...@gmail.com
Fixes: 017c59c042d01 ("relay: Use per CPU constructs for the relay channel 
buffer pointers")
Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com>
Cc: Jens Axboe <ax...@suse.de>
Cc: Thomas Gleixner <t...@linutronix.de>
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
Signed-off-by: Linus Torvalds <torva...@linux-foundation.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 include/linux/relay.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/relay.h b/include/linux/relay.h
index 68c1448e56bb..2560f8706408 100644
--- a/include/linux/relay.h
+++ b/include/linux/relay.h
@@ -65,7 +65,7 @@ struct rchan
        struct kref kref;               /* channel refcount */
        void *private_data;             /* for user-defined data */
        size_t last_toobig;             /* tried to log event > subbuf size */
-       struct rchan_buf ** __percpu buf; /* per-cpu channel buffers */
+       struct rchan_buf * __percpu *buf; /* per-cpu channel buffers */
        int is_global;                  /* One global buffer ? */
        struct list_head list;          /* for channel list */
        struct dentry *parent;          /* parent dentry passed to open */
-- 
2.19.1



Reply via email to