On 4/4/2019 7:47 PM, Yue Haibing wrote:
From: YueHaibing <yuehaib...@huawei.com>
As Hans de Goede pointed, using this driver without ACPI
makes little sense, so add ACPI dependency to Kconfig entry
to fix a build error while CONFIG_ACPI is not set.
drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to
incomplete type
put_device(&adev->dev);
Fixes: 0cf064db948a ("extcon: axp288: Convert to use
acpi_dev_get_first_match_dev()")
Reported-by: Hulk Robot <hul...@huawei.com>
Suggested-by: Hans de Goede <hdego...@redhat.com>
Signed-off-by: YueHaibing <yuehaib...@huawei.com>
This looks good too.
Reviewed-by: Mukesh Ojha <mo...@codeaurora.org>
Cheers,
-Mukesh
---
v2: rework patch
---
drivers/extcon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 1ed4b45..de06faf 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -30,7 +30,7 @@ config EXTCON_ARIZONA
config EXTCON_AXP288
tristate "X-Power AXP288 EXTCON support"
- depends on MFD_AXP20X && USB_SUPPORT && X86
+ depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
select USB_ROLE_SWITCH
help
Say Y here to enable support for USB peripheral detection
