On 06/04/2019 11.32, Borislav Petkov wrote: > On Fri, Apr 05, 2019 at 09:25:27AM -0700, Matthew Wilcox wrote: >> I don't think that's a good idea; we should only document functions we >> want other people to use. > > Yap.
Exactly, not kernel-doc'ing was a deliberate choice. >> I could also go for renaming this to __size_ab_plus_c. > > Let's just leave it short as it is now - the comment should be good > enough. > > Btw, is anyone picking this up or should I? I'm fine with you picking it up. Here's a real changelog, feel free to edit. overflow.h: add comment documenting __ab_c_size() __ab_c_size() is a somewhat opaque name. Document its purpose, and while at it, rename the parameters to actually match the abc naming. Rasmus