Re: [BUG] Rockchip SPI: long burst writes produce unexpected result

Vicente Bergas Sat, 06 Apr 2019 17:38:42 -0700

Hi,
please, forget my previous mail about
 eff0275e5253604429aedc42b008c5fcaa6cc597
 spi: rockchip: simplify use_dma logic
i messed up with commit IDs, sorry.


The first offending commit is one later than that:
commit 420b82f842941a32adf309ca1b193adfc77616b0
Date:   Wed Oct 31 11:57:07 2018 +0100

   spi: rockchip: set min/max speed

The driver previously checked each transfer if the

   requested speed was higher than possible with the
   current spi clock rate and raised the clock rate
   accordingly.

However, there is no check to see if the spi clock

   was actually set that high and no way to dynamically
   lower the spi clock rate again.

So it seems any potiential users of this functionality

   are better off just setting the spi clock rate at init
   using the assigned-clock-rates devicetree property.

Removing this dynamic spi clock rate raising allows

   us let the spi framework handle min/max speeds
   for us.

Regards,
 Vicenç.

On Saturday, April 6, 2019 7:34:32 PM CEST, Vicente Bergas wrote:

Hi,
i have been experiencing issues writing to NOR-Flash SPI Memories
from two RK3399-based platforms: gru-kevin and sapphire board.
For kevin, this resulted in a bricked device because that memory
is the only boot device.
Fortunately an external programmer is available.

In order to isolate where the issue can be, several tests have been
done, after which it makes me think the issue is related to the
Rockchip SPI driver.

4KB burst reads work fine.
The issue is only observed on the write burst length.
Test user user/kernel kernel RK3399 Num spaceinterface space SoC Status Notes--------------------------------------------------------
1    flashrom linux_mtd   MTD/RKspi RKspi   Fail
2    flashrom linux_spi   RKspi     RKspi   Fail
3    flashrom linux_spi   spi_gpio  GPIO    OK
4    custom   linux_spi   spi_gpio  GPIO    OK   260-byte burst writes
5    custom   linux_spi   RKspi     RKspi   Fail 260-byte burst writes
6    custom   linux_spi   RKspi     RKspi   OK     1-byte burst writes
7    custom   linux_spi   RKspi     RKspi   OK    47-byte burst writes
8    custom   linux_spi   RKspi     RKspi   Fail  48-byte burst writes

3, 4) Unaccetably slow, device tree is
 spi_gpio {
   compatible = "spi-gpio";
   #address-cells = <1>;
   #size-cells = <0>;
   cs-gpios   = <&gpio1 RK_PB2 GPIO_ACTIVE_HIGH>;
   sck-gpios  = <&gpio1 RK_PB1 GPIO_ACTIVE_HIGH>;
   mosi-gpios = <&gpio1 RK_PB0 GPIO_ACTIVE_HIGH>;
   miso-gpios = <&gpio1 RK_PA7 GPIO_ACTIVE_HIGH>;
   num-chipselects = <1>;
   spidev@0 {
     compatible = "spidev";
     reg = <0>;
     spi-max-frequency = <50000000>;
   };
 };
2, 5, 6, 7, 8) device tree is
 &spi1 {
   status = "okay";
   spidev@0 {
     compatible = "spidev";
     reg = <0>;
     spi-max-frequency = <50000000>;
   };
 };
5, 6, 7, 8) Burst writes are performed this way
 enum { BURST = 48 };
 struct spi_ioc_transfer msg[0x105];
 unsigned i = 0;
 for (unsigned j = 0; j < wcnt; j += BURST) {
   msg[i++] = { .tx_buf = warr, .len = BURST<wcnt-j ? BURST : wcnt-j };
   warr += BURST;
 }
 if (rcnt)
   msg[i++] = { .rx_buf = rarr, .len = rcnt };
 ioctl(fd, SPI_IOC_MESSAGE(i), msg);
1, 2, 5, 8) I have no logic analyzer to see what is happenning on the
SPI bus, but when it fails at 48-byte bursts, the contents of the memory
are like this:
Addr Expected                                        Actual
000 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF010 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF020 FF FF FF FF FF FF FF FF FF FF FF FF F1 F2 F3 F4 FF FF FFFF FF FF FF FF FF F1 F2 F3 F4 FF FF FF030 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF040 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF050 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF060 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF070 FF FF FF FF FF FF FF FF FF FF FF FF E1 E2 E3 E4 FF FF FFFF FF FF E1 E2 E3 E4 FF FF FF FF FF FF080 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF090 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF0A0 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF0B0 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF0C0 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF0D0 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF0E0 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF0F0 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF780 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 00790 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 007A0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 007B0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 007C0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 007D0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 007E0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 007F0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 FF FFFF FF FF FF FF FF FF FF FF FF FF FF FF800 01 02 03 04 00 00 00 00 00 00 00 00 00 00 00 00 01 02 0304 00 00 00 00 00 00 00 00 00 00 00 00810 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 00820 00 00 00 00 00 00 00 00 00 00 00 00 05 06 07 08 00 00 0000 00 00 00 00 00 05 06 07 08 00 00 00830 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 00840 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 00850 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 00860 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 00870 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 00
Regards,
 Vicenç.

Re: [BUG] Rockchip SPI: long burst writes produce unexpected result

Reply via email to