Hi Mark, > -----Original Message----- > From: Mark Brown <[email protected]> > Sent: Wednesday, April 10, 2019 4:01 PM > To: Naga Sureshkumar Relli <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > linux- > [email protected]; Michal Simek <[email protected]>; > [email protected] > Subject: Re: [LINUX PATCH v2] spi: spi-mem: Fix build error without > CONFIG_SPI_MEM > > On Wed, Apr 10, 2019 at 11:14:45AM +0530, Naga Sureshkumar Relli wrote: > > When building with CONFIG_SPI_MEM is not set gc warns this: > > > > drivers/spi/spi-zynq-qspi.o: In function `zynq_qspi_supports_op': > > spi-zynq-qspi.c:(.text+0x1da): undefined reference to > > `spi_mem_default_supports_op' > > > > Fixes: 67dca5e580f1 ("spi: spi-mem: Add support for Zynq QSPI > > controller") > > > > Signed-off-by: YueHaibing <[email protected]> > > Signed-off-by: Naga Sureshkumar Relli > > <[email protected]> > > Why is there a signed off by for YueHaibing here? Did they write the patch > (in which case the > authorship is incorrect)? Yes, YueHaibing has wrote this patch. I will update the Author name.
> > You've also got an extra blank line between the Fixes and the rest of the > tags which is unusual > and might confuse some tools. Ok I will remove that extra line. Thanks, Naga Sureshkumar Relli
