On Thu, Apr 11, 2019 at 2:30 AM Masahiro Yamada <[email protected]> wrote: > My plan is to rewrite all VDSO Makefiles to use $(LD), then delete > cc-ldoption.
I too look forward to the removal of cc-ldoption. Thanks for the patch. Based on some of the discussion in a similar patch for aarch64: https://lkml.org/lkml/2019/4/12/760: Reviewed-by: Nick Desaulniers <[email protected]> > > Signed-off-by: Masahiro Yamada <[email protected]> > --- > > arch/arm/vdso/Makefile | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) > > diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile > index f4efff9d3afb..fadf554d9391 100644 > --- a/arch/arm/vdso/Makefile > +++ b/arch/arm/vdso/Makefile > @@ -10,12 +10,12 @@ obj-vdso := $(addprefix $(obj)/, $(obj-vdso)) > ccflags-y := -fPIC -fno-common -fno-builtin -fno-stack-protector > ccflags-y += -DDISABLE_BRANCH_PROFILING > > -VDSO_LDFLAGS := -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 > -VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 > -VDSO_LDFLAGS += -nostdlib -shared > -VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > -VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--build-id) > -VDSO_LDFLAGS += $(call cc-ldoption, -fuse-ld=bfd) > +ldflags-y = -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ > + -z max-page-size=4096 -z common-page-size=4096 \ This reminds me that I should resend: https://lore.kernel.org/patchwork/patch/1023578/ -- Thanks, ~Nick Desaulniers
