On (04/12/19 22:11), Paul Gortmaker wrote:
> In commit b1fca27d384e ("kernel debug: support resetting WARN*_ONCE")
> we got the opportunity to reset state on the one shot messages,
> without having to reboot.
Didn't know that.
> However printk_once (printk_deferred_once) live in a different file
> and didn't get the same kind of update/conversion, so they remain
> unconditionally one shot, until the system is rebooted.
>
> For example, we currently have:
>
> sched/rt.c: printk_deferred_once("sched: RT throttling activated\n");
>
> ..which could reasonably be tripped as someone is testing and tuning
> a new system/workload and their task placements. For consistency, and
> to avoid reboots in the same vein as the original commit, we make these
> two instances of _once the same as the WARN*_ONCE instances are.
Looks OK to me.
Reviewed-by: Sergey Senozhatsky <[email protected]>
-ss
