On 2019/4/24 16:11, Leonard Crestez wrote: > On 4/24/2019 11:00 AM, Yue Haibing wrote: >> From: YueHaibing <[email protected]> >> >> During randconfig builds, I occasionally run into an invalid configuration >> >> drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init': >> soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register' >> >> while CONFIG_SOC_BUS is not set, the building failed like this. This patch >> selects SOC_BUS to fix it. >> >> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig >> @@ -5,6 +5,7 @@ config IMX_GPCV2_PM_DOMAINS >> depends on ARCH_MXC || (COMPILE_TEST && OF) >> depends on PM >> select PM_GENERIC_DOMAINS >> + select SOC_BUS >> default y if SOC_IMX7D > > You should "select SOC_BUS" from "config ARCH_MXC" in arm64 > Kconfig.platforms, not from a power domain implementation. > > Your patch works because arm64 ARCH_MXC currently does "select > IMX_GPCV2_PM_DOMAINS" but it's silly to use this intermediary.
Yes, you are right, thanks! > > -- > Regards, > Leonard > >
