Ping...

> -----Original Message-----
> From: Mukesh Ojha [mailto:[email protected]]
> Sent: Monday, April 1, 2019 4:01 PM
> To: Anson Huang <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected]
> Cc: dl-linux-imx <[email protected]>
> Subject: Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource()
> to simplify code
> 
> 
> On 4/1/2019 10:54 AM, Anson Huang wrote:
> > Use the new helper devm_platform_ioremap_resource() which wraps the
> > platform_get_resource() and devm_ioremap_resource() together, to
> > simplify the code.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> 
> 
> Reviewed-by: Mukesh Ojha <[email protected]>
> 
> Cheers,
> -Mukesh
> 
> > ---
> >   drivers/pwm/pwm-imx27.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c index
> > 8061306..434a351 100644
> > --- a/drivers/pwm/pwm-imx27.c
> > +++ b/drivers/pwm/pwm-imx27.c
> > @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
> >   static int pwm_imx27_probe(struct platform_device *pdev)
> >   {
> >     struct pwm_imx27_chip *imx;
> > -   struct resource *r;
> >
> >     imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
> >     if (imx == NULL)
> > @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct
> platform_device *pdev)
> >     imx->chip.of_xlate = of_pwm_xlate_with_flags;
> >     imx->chip.of_pwm_n_cells = 3;
> >
> > -   r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -   imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
> > +   imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
> >     if (IS_ERR(imx->mmio_base))
> >             return PTR_ERR(imx->mmio_base);
> >

Reply via email to