[...]
> +
> +static void sdhci_milbeaut_power_off(struct sdhci_host *host)
> +{
> + struct f_sdhost_priv *priv = sdhci_priv(host);
> +
> + gpiod_set_value(priv->power_gpio, 0);
> + udelay(1000);
> +}
> +
> +static void sdhci_milbeaut_power_on(struct sdhci_host *host)
> +{
> + struct f_sdhost_priv *priv = sdhci_priv(host);
> +
> + gpiod_set_value(priv->power_gpio, 1);
> +}
> +
As stated for the DT doc patch, please use a fixed GPIO regulator
instead. In this way you will also get a the OCR mask based upon the
GPIO regulator, which is parsed out by the mmc core when sdhci calls
mmc_regulator_get_supply().
Otherwise, this looks good to me.
[...]
Kind regards
Uffe
