On Mon, Apr 29, 2019 at 05:16:16PM +0800, Kai-Heng Feng wrote: > at 05:47, Andy Shevchenko <[email protected]> wrote: > > On Mon, Apr 22, 2019 at 12:45:39PM +0800, Kai-Heng Feng wrote: > > > Commit a939bb57cd47 ("pinctrl: intel: implement gpio_irq_enable") was > > > added because clearing interrupt status bit is required to avoid > > > unexpected behavior. > > > > > > Turns out the unmask callback also needs the fix, which can solve weird > > > IRQ triggering issues on I2C touchpad ELAN1200.
> > Is it possible scenario when IRQ enable is called, but not masking > > callbacks? > > For _AEI or GPE? > > I am unfamiliar with both of them, what are the callbacks to be used for > _AEI and GPE case? > Seems like both gpiolib and irqchip call irq_unmask() when irq_enable() is > absent. Yes, that's correct, thank you for double checking. * @irq_enable: enable the interrupt (defaults to chip->unmask if NULL) Wait for v2 with mentioned earlier changes and gathered tags. -- With Best Regards, Andy Shevchenko
