On Mon, Apr 29, 2019 at 8:29 AM Mathieu Desnoyers <[email protected]> wrote: > > Ongoing work for asm goto support from clang requires the > -no-integrated-as compiler flag. > > This compiler flag is present in the toplevel kernel Makefile, > but is not replicated for selftests. Add it specifically for > the rseq selftest which requires asm goto. > > Link: https://reviews.llvm.org/D56571 > Signed-off-by: Mathieu Desnoyers <[email protected]> > CC: Nick Desaulniers <[email protected]> > CC: Thomas Gleixner <[email protected]> > CC: Joel Fernandes <[email protected]> > CC: Peter Zijlstra <[email protected]> > CC: Catalin Marinas <[email protected]> > CC: Dave Watson <[email protected]> > CC: Will Deacon <[email protected]> > CC: Shuah Khan <[email protected]> > CC: Andi Kleen <[email protected]> > CC: [email protected] > CC: "H . Peter Anvin" <[email protected]> > CC: Chris Lameter <[email protected]> > CC: Russell King <[email protected]> > CC: Michael Kerrisk <[email protected]> > CC: "Paul E . McKenney" <[email protected]> > CC: Paul Turner <[email protected]> > CC: Boqun Feng <[email protected]> > CC: Josh Triplett <[email protected]> > CC: Steven Rostedt <[email protected]> > CC: Ben Maurer <[email protected]> > CC: [email protected] > CC: Andy Lutomirski <[email protected]> > CC: Andrew Morton <[email protected]> > CC: Linus Torvalds <[email protected]> > --- > tools/testing/selftests/rseq/Makefile | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/rseq/Makefile > b/tools/testing/selftests/rseq/Makefile > index c30c52e1d0d2..d6469535630a 100644 > --- a/tools/testing/selftests/rseq/Makefile > +++ b/tools/testing/selftests/rseq/Makefile > @@ -1,5 +1,11 @@ > # SPDX-License-Identifier: GPL-2.0+ OR MIT > -CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L./ -Wl,-rpath=./ > + > +ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),) > +CLANG_FLAGS += -no-integrated-as > +endif > + > +CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L./ -Wl,-rpath=./ \ > + $(CLANG_FLAGS)
The top level Makefile exports $(CLANG_FLAGS), which should contain `-no-integrated-as`. Is that available here? If so, then you can just add `$(CLANG_FLAGS)`, no compiler check needed. If not, maybe the test for CONFIG_CC_IS_CLANG is cleaner? Thanks for the patch, and helping test asm goto in Clang! -- Thanks, ~Nick Desaulniers
