On Mon, Apr 29, 2019 at 10:12 AM Patrick Venture <[email protected]> wrote: > > On Mon, Apr 29, 2019 at 10:08 AM Olof Johansson <[email protected]> wrote: > > > > On Thu, Apr 25, 2019 at 07:25:49PM +0200, Greg KH wrote: > > > On Tue, Apr 23, 2019 at 08:28:14AM -0700, Patrick Venture wrote: > > > > On Tue, Apr 23, 2019 at 8:22 AM Patrick Venture <[email protected]> > > > > wrote: > > > > > > > > > > On Tue, Apr 23, 2019 at 7:26 AM Patrick Venture <[email protected]> > > > > > wrote: > > > > > > > > > > > > Create a SoC folder for the ASPEED parts and place the misc drivers > > > > > > currently present into this folder. These drivers are not generic > > > > > > part > > > > > > drivers, but rather only apply to the ASPEED SoCs. > > > > > > > > > > > > Signed-off-by: Patrick Venture <[email protected]> > > > > > > > > > > Accidentally lost the Acked-by when re-sending this patchset as I > > > > > didn't see it on v1 before re-sending v2 to the larger audience. > > > > > > > > Since there was a change between v1 and v2, Arnd, I'd appreciate you > > > > Ack this version of the patchset since it changes when the soc/aspeed > > > > Makefile is followed. > > > > > > I have no objection for moving stuff out of drivers/misc/ so the SOC > > > maintainers are free to take this. > > > > > > Acked-by: Greg Kroah-Hartman <[email protected]> > > > > I'm totally confused. This is the second "PATCH v2" of this patch that I > > came > > across, I already applied the first. > > I think the issue here was that I added to the CC list another email > and so you may see the v2 without that mailing list, and a v2 with it > -- > > Does this require a v3? I honestly didn't think so, but this was the > first time I had to add more people without needing other changes.
Well, v2 doesn't build. I'll fix it up locally by adding an 'endmenu' to drivers/soc/aspeed/Kconfig. But... brings up questions how this was tested before submitting? scripts/kconfig/conf --allnoconfig Kconfig drivers/soc/Kconfig:24: 'menu' in different file than 'menu' drivers/soc/aspeed/Kconfig:1: location of the 'menu' drivers/Kconfig:233: 'menu' in different file than 'menu' drivers/soc/aspeed/Kconfig:1: location of the 'menu' <none>:34: syntax error > > > > Patrick: Follow up with incremental patch in case there's any difference. > > Meanwhile, please keep in mind that you're adding a lot of work for people > > when > > you respin patches without following up on the previous version. Thanks! > > w.r.t this patch series. I found an issue with v1, and released a v2 > with the detail of what changed. I thought that was the correct > approach. I apologize for creating extra work, that's something > nobody needs. It's ok to submit newer versions, but it's convenient when they get threaded also in non-gmail mail readers (by using in-reply-to). -Olof
