On 2019-05-02 07:42:14 [-0700], Andy Lutomirski wrote: > The FPU is not a super-Linuxy internal detail, so remove the _GPL > from its export. Without something like this patch, it's impossible > for even highly license-respecting non-GPL modules to use the FPU, > which seems silly to me. After all, the FPU is a CPU feature, not > really a kernel feature at all. > > Cc: Sebastian Andrzej Siewior <[email protected]> > Cc:: Borislav Petkov <[email protected]> > Cc: Rik van Riel <[email protected]> > Cc: "H. Peter Anvin" <[email protected]> > Cc: "Jason A. Donenfeld" <[email protected]> > Cc: Ard Biesheuvel <[email protected]> > Cc: Dave Hansen <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Nicolai Stange <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Cc: Radim Krčmář <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: [email protected] > Cc: [email protected] > Fixes: 12209993e98c ("x86/fpu: Don't export __kernel_fpu_{begin,end}()") > Signed-off-by: Andy Lutomirski <[email protected]> > --- > > This fixes a genuine annoyance for ZFS on Linux. Regardless of what > one may think about the people who distribute ZFS on Linux > *binaries*, as far as I know, the source and the users who build it > themselves are entirely respectful of everyone's license. I have no > problem with EXPORT_SYMBOL_GPL() in general, but let's please avoid > using it for things that aren't fundamentally Linux internals.
Please don't start this. We have everything _GPL that is used for FPU related code and only a few functions are exported because KVM needs it. Also with the recent FPU rework it is much easier to get this wrong so I would not want for any OOT code to mess with it. And again: It does not change whether or not ZFS can be used on Linux (excluding the license issue). They simply can't use crc32 with their SSE assembly and this is it. Sebastian
