On Thu 2019-05-02 10:59:58, Nikitas Angelinas wrote: > On Thu, May 02, 2019 at 12:15:00PM +0200, Pavel Machek wrote: > > On Thu 2019-05-02 00:43:05, Nikitas Angelinas wrote: > > > There is no need to keep sysrq_poweroff_op after initialization, so mark > > > it with __initdata. > > > > Are you sure? > > > > pavel@duo:/data/l/k$ grep -ri sysrq_key_op . | grep initdata > > pavel@duo:/data/l/k$ > > > > > > Pavel > > > I am sorry about this. I completely missed the point of registering this > structure. Please ignore this patch. >
Yup. You can have Acked-by: for the other parts.
Pavel
> > >
> > > -static struct sysrq_key_op sysrq_poweroff_op = {
> > > +static struct sysrq_key_op sysrq_poweroff_op __initdata = {
> > > .handler = handle_poweroff,
> > > .help_msg = "poweroff(o)",
> > > .action_msg = "Power Off",
> >
> > --
> > (english) http://www.livejournal.com/~pavelmachek
> > (cesky, pictures)
> > http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
