On 02-05-19, 08:00, Bjorn Andersson wrote:
> On Thu 02 May 04:53 PDT 2019, Vinod Koul wrote:
> > On 01-05-19, 17:19, Bjorn Andersson wrote:
> [..]
> > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c
> > > b/drivers/pci/controller/dwc/pcie-qcom.c
> > > index 0ed235d560e3..d740cbe0e56d 100644
> > > --- a/drivers/pci/controller/dwc/pcie-qcom.c
> > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> > > @@ -112,10 +112,10 @@ struct qcom_pcie_resources_2_3_2 {
> > > struct regulator_bulk_data supplies[QCOM_PCIE_2_3_2_MAX_SUPPLY];
> > > };
> > >
> > > +#define QCOM_PCIE_2_4_0_MAX_CLOCKS 3
> >
> > empty line after the define please
> >
>
> This follows the style of QCOM_PCIE_2_3_2_MAX_SUPPLY one block up, so
> I think this is the way we want it.
Okay sounds fine to me
>
> > > struct qcom_pcie_resources_2_4_0 {
> [..]
> >
> >
> > rest lgtm:
> >
> > Reviewed-by: Vinod Koul <vk...@kernel.org>
> >
>
> Thanks!
>
> Regards,
> Bjorn
--
~Vinod
