> -----Original Message----- > From: Gustavo A. R. Silva [mailto:[email protected]] > Sent: Tuesday, April 30, 2019 10:32 PM > To: Michael Turquette <[email protected]>; Stephen Boyd > <[email protected]>; Shawn Guo <[email protected]>; Sascha Hauer > <[email protected]>; Pengutronix Kernel Team > <[email protected]>; Fabio Estevam <[email protected]>; dl-linux- > imx <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; Gustavo A. R. Silva <[email protected]> > Subject: [PATCH] clk: imx: clk-pllv3: mark expected switch fall-throughs > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases where > we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/clk/imx/clk-pllv3.c: In function ‘imx_clk_pllv3’: > drivers/clk/imx/clk-pllv3.c:446:18: warning: this statement may fall through > [- > Wimplicit-fallthrough=] > pll->div_shift = 1; > ~~~~~~~~~~~~~~~^~~ > drivers/clk/imx/clk-pllv3.c:447:2: note: here > case IMX_PLLV3_USB: > ^~~~ > drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through > [- > Wimplicit-fallthrough=] > pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > ^ > drivers/clk/imx/clk-pllv3.c:454:2: note: here > case IMX_PLLV3_AV: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <[email protected]> > --- > drivers/clk/imx/clk-pllv3.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c index > e892b9a836e5..4110e713d259 100644 > --- a/drivers/clk/imx/clk-pllv3.c > +++ b/drivers/clk/imx/clk-pllv3.c > @@ -444,6 +444,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, > const char *name, > break; > case IMX_PLLV3_USB_VF610: > pll->div_shift = 1; > + /* fall through */ > case IMX_PLLV3_USB: > ops = &clk_pllv3_ops; > pll->powerup_set = true; > @@ -451,6 +452,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, > const char *name, > case IMX_PLLV3_AV_IMX7: > pll->num_offset = PLL_IMX7_NUM_OFFSET; > pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > + /* fall through */
Reviewed-by: Anson Huang <[email protected]> > case IMX_PLLV3_AV: > ops = &clk_pllv3_av_ops; > break; > -- > 2.21.0
