On Wed, May 08, 2019 at 11:42:01PM +0100, Colin King wrote: > From: Colin Ian King <[email protected]> > > The variable tad_base is being set to a value that is never read > and is being over-written on the next iteration of a for-loop. > This assignment is therefore redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <[email protected]> > --- > drivers/edac/sb_edac.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c > index 9353c3fc7c05..6aa4b1b73a15 100644 > --- a/drivers/edac/sb_edac.c > +++ b/drivers/edac/sb_edac.c > @@ -1513,7 +1513,6 @@ static int knl_get_dimm_capacity(struct sbridge_pvt > *pvt, u64 *mc_sizes) > sad_actual_size[mc] += tad_size; > } > } > - tad_base = tad_limit+1; > } > } >
Looks good to me. Acked-by: Tony Luck <[email protected]>
