On Fri, 2019-05-10 at 12:14 +0200, Bartosz Golaszewski wrote: > pt., 10 maj 2019 o 11:58 Colin King <[email protected]> napisał(a): > > > > From: Colin Ian King <[email protected]> > > > > Pointer dev is being dereferenced when passed to the inlined > > functon dev_name, however, dev is later being null checked > > so at first this seems like a potential null pointer dereference. > > > > In fact, _reset_control_get_from_lookup is only ever called from > > __reset_control_get, right after checking dev->of_node hence > > dev can never be null. Clean this up by removing the redundant > > null check. > > > > Thanks to Philipp Zabel for spotting that dev can never be null. > > > > Addresses-Coverity: ("Dereference before null check") > > Fixes: 6691dffab0ab ("reset: add support for non-DT systems") > > Signed-off-by: Colin Ian King <[email protected]> [...] > Reviewed-by: Bartosz Golaszewski <[email protected]>
Thank you both, applied to reset/fixes. regards Philipp
