Fenghua/Andre,
On 5/10/19 2:29 PM, Yu, Fenghua wrote: > [CAUTION: External Email] > >> On Friday, May 10, 2019 10:40 AM >> Andre Przywara [mailto:[email protected]] wrote: >> To: Yu, Fenghua <[email protected]> >> Cc: Thomas Gleixner <[email protected]>; Ingo Molnar >> <[email protected]>; Borislav Petkov <[email protected]>; H Peter Anvin >> <[email protected]>; Luck, Tony <[email protected]>; Chatre, Reinette >> <[email protected]>; Shankar, Ravi V <[email protected]>; >> Shen, Xiaochen <[email protected]>; Pathan, Arshiya Hayatkhan >> <[email protected]>; Prakhya, Sai Praneeth >> <[email protected]>; Babu Moger <[email protected]>; >> linux-kernel <[email protected]>; James Morse >> <[email protected]> >> Subject: Re: [PATCH v7 12/13] selftests/resctrl: Disable MBA and MBM tests >> for AMD >> >> On Sat, 9 Feb 2019 18:50:41 -0800 >> Fenghua Yu <[email protected]> wrote: >> >> Hi, >> >>> From: Babu Moger <[email protected]> >>> >>> For now, disable MBA and MBM tests for AMD. Deciding test pass/fail is >>> not clear right now. We can enable when we have some clarity. >> >> I don't think this is the right way. The availability of features should be >> queryable, for instance by looking into /sys/fs/resctrl/info. Checking for a >> certain vendor to skip tests just sounds wrong to me, and is definitely not >> scalable or future proof. >> >> We should really check the availability of a feature, then skip the whole >> subsystem test in resctrl_tests.c. > > Babu may correct if I'm wrong: AMD does support the MBA and MBM features. So > if querying the info directory, the features are there. But AMD doesn't want > to support the testing for the features in the current patch set. They may > support the testing in the future. Yes. AMD supports the MBA and MBM features. But, deciding the test pass/fail was not clear to me. That is why I decided to disable the test for now. Right now, it reports the test result as "fail". We can add the test in the future with some modifications. > > Thanks. > > -Fenghua >
