Re: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support

[Keerthy]

On 15/05/19 4:38 PM, Mark Brown wrote:

On Wed, May 15, 2019 at 03:38:48PM +0530, Keerthy wrote:

@@ -172,6 +178,9 @@ static int lp87565_regulator_probe(struct platform_device 
*pdev)
        if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
                min_idx = LP87565_BUCK_10;
                max_idx = LP87565_BUCK_23;
+       } else if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87561_Q1) {
+               min_idx = LP87565_BUCK_3210;
+               max_idx = LP87565_BUCK_3210;

This if/else chain should be a switch statement.

Okay. I will convert that in v2.

Thanks,
Keerthy