Hi Nicolas, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [also build test WARNING on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nicolas-Boichat/mm-failslab-By-default-do-not-fail-allocations-with-direct-reclaim-only/20190521-045221 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> sparse warnings: (new ones prefixed by >>) >> mm/failslab.c:27:26: sparse: sparse: restricted gfp_t degrades to integer vim +27 mm/failslab.c 16 17 bool __should_failslab(struct kmem_cache *s, gfp_t gfpflags) 18 { 19 /* No fault-injection for bootstrap cache */ 20 if (unlikely(s == kmem_cache)) 21 return false; 22 23 if (gfpflags & __GFP_NOFAIL) 24 return false; 25 26 if (failslab.ignore_gfp_reclaim && > 27 (gfpflags & ___GFP_DIRECT_RECLAIM)) 28 return false; 29 30 if (failslab.cache_filter && !(s->flags & SLAB_FAILSLAB)) 31 return false; 32 33 return should_fail(&failslab.attr, s->object_size); 34 } 35 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
