Hi, Shawn > -----Original Message----- > From: Shawn Guo [mailto:[email protected]] > Sent: Thursday, May 23, 2019 8:41 PM > To: Anson Huang <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > Leonard Crestez <[email protected]>; Abel Vesa > <[email protected]>; [email protected]; linux-arm- > [email protected]; [email protected]; dl-linux-imx > <[email protected]> > Subject: Re: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary > of_node_put() in error handling > > On Tue, May 21, 2019 at 09:18:43AM +0000, Anson Huang wrote: > > of_node_put() is called after of_match_node() successfully called, > > then in the following error handling, of_node_put() is called again > > which is unnecessary, this patch adjusts the location of of_node_put() > > to avoid such scenario. > > > > Signed-off-by: Anson Huang <[email protected]> > > Again, there are '=20' in the patch content and I cannot apply it.
I resent the patch set, please pick them up, thanks. https://patchwork.kernel.org/patch/10959101/ https://patchwork.kernel.org/patch/10959099/ Anson. > > Shawn > > > --- > > drivers/soc/imx/soc-imx8.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c > > index b1bd8e2..944add2 100644 > > --- a/drivers/soc/imx/soc-imx8.c > > +++ b/drivers/soc/imx/soc-imx8.c > > @@ -86,8 +86,6 @@ static int __init imx8_soc_init(void) > > if (!id) > > goto free_soc; > > > > - of_node_put(root); > > - > > data = id->data; > > if (data) { > > soc_dev_attr->soc_id = data->name; > > @@ -106,6 +104,8 @@ static int __init imx8_soc_init(void) > > if (IS_ENABLED(CONFIG_ARM_IMX_CPUFREQ_DT)) > > platform_device_register_simple("imx-cpufreq-dt", -1, NULL, > 0); > > > > + of_node_put(root); > > + > > return 0; > > > > free_rev: > > -- > > 2.7.4 > >
