On Fri, 2019-05-24 at 19:55 +0200, Heiner Kallweit wrote:
> On 24.05.2019 17:14, Paul Menzel wrote:
> > I applied the simple change below to `net/core/rtnetlink.c`.
> >
> > if (err < 0)
> > - net_warn_ratelimited("A link change request failed
> > with some changes committed already. Interface %s may have been left with
> > an inconsistent configuration, please check.\n",
> > - dev->name);
> > + net_warn_ratelimited("A link change request failed
> > with some changes committed already (err = %i). Interface %s may have been
> > left with an inconsistent configuration, please check.\n",
> > + dev->name, err);
> >
> > I get different results each time.
> >
> > -304123904
> > -332128256
> >
> > Any idea, how that can happen?
> >
> Instead of %i you should use %d, and the order of arguments needs to be
> reversed.
Doesn't the patch generate a compilation warning?
