Re: [PATCH v14 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

[Pavel Machek]

Hi!

> +     leds {
> +             compatible = "gpio-leds";
> +             pinctrl-names = "default";
> +             pinctrl-0 = <&pinctrl_gpio_leds>;
> +
> +             led1 {
> +                     label = "LED 1";
> +                     gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
> +                     default-state = "off";
> +             };
> +     };

I had comments about these...

> +     vibrator {
> +             compatible = "gpio-vibrator";
> +             pinctrl-names = "default";
> +             pinctrl-0 = <&pinctrl_haptic>;
> +             enable-gpios = <&gpio5 4 GPIO_ACTIVE_LOW>;
> +             vcc-supply = <&reg_3v3_p>;
> +     };

Thanks!

> +     charger@6b { /* bq25896 */
> +             compatible = "ti,bq25890";
> +             reg = <0x6b>;
> +             pinctrl-names = "default";
> +             pinctrl-0 = <&pinctrl_charger>;
> +             interrupt-parent = <&gpio3>;
> +             interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
> +             ti,battery-regulation-voltage = <4192000>; /* 4.192V */
> +             ti,charge-current = <1600000>; /* 1.6 A */
> +             ti,termination-current = <66000>;  /* 66mA */
> +             ti,precharge-current = <1300000>; /* 1.3A */
> +             ti,minimum-sys-voltage = <2750000>; /* 2.75V */
> +             ti,boost-voltage = <5000000>; /* 5V */
> +             ti,boost-max-current = <50000>; /* 50mA */
> +     };

And this. Did they get lost somewhere?
                                                                        Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

signature.asc
Description: Digital signature