On 2019/5/24 23:00, Eric Dumazet wrote: > On Fri, May 24, 2019 at 7:30 AM Kefeng Wang <[email protected]> > wrote: >> 3e67f106f619 ("inet: frags: break the 2GB limit for frags storage"), >> changes ipfrag_high/low_thread 'type' from int to long, using CTL_ULONG >> instead of CTL_INT to keep consistent. > > What about compatibility with existing applications ? > Will there sysctl() fail if they provide 32bit variable ? > > /proc/sys/net files are text files, but sysctl() system call has been > discouraged for more than a decade.
The sysctl() system call is deprecated, so the main purpose of this patch is to keep consistent, but it does set wrong value(eg, set 16000000000 to ipfrag_high_thresh) when use sysctl(). > >
