There is no need to compare hw_id with < 0 because such comparison
of an unsigned value is always false.

Fix this by removing such comparison.

Addresses-Coverity-ID: 1445440 ("Unsigned compared against 0")
Fixes: 3e6a8fb33084 ("drivers: thermal: tsens: Add new operation to check if a 
sensor is enabled")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
 drivers/thermal/qcom/tsens-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/qcom/tsens-common.c 
b/drivers/thermal/qcom/tsens-common.c
index 928e8e81ba69..94878ad35464 100644
--- a/drivers/thermal/qcom/tsens-common.c
+++ b/drivers/thermal/qcom/tsens-common.c
@@ -69,7 +69,7 @@ bool is_sensor_enabled(struct tsens_priv *priv, u32 hw_id)
        u32 val;
        int ret;
 
-       if ((hw_id > (priv->num_sensors - 1)) || (hw_id < 0))
+       if (hw_id > priv->num_sensors - 1)
                return -EINVAL;
        ret = regmap_field_read(priv->rf[SENSOR_EN], &val);
        if (ret)
-- 
2.21.0

Reply via email to