Em Thu, May 30, 2019 at 05:38:01PM +0800, Leo Yan escreveu: > Variable 'err' is defined but never used in function symsrc__init(), > remove it and directly return -1 at the end of the function.
Thanks, applied. - Arnaldo > Signed-off-by: Leo Yan <[email protected]> > --- > tools/perf/util/symbol-elf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c > index 4ad106a5f2c0..fdc5bd7dbb90 100644 > --- a/tools/perf/util/symbol-elf.c > +++ b/tools/perf/util/symbol-elf.c > @@ -699,7 +699,6 @@ bool __weak elf__needs_adjust_symbols(GElf_Ehdr ehdr) > int symsrc__init(struct symsrc *ss, struct dso *dso, const char *name, > enum dso_binary_type type) > { > - int err = -1; > GElf_Ehdr ehdr; > Elf *elf; > int fd; > @@ -793,7 +792,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso, > const char *name, > elf_end(elf); > out_close: > close(fd); > - return err; > + return -1; > } > > /** > -- > 2.17.1 -- - Arnaldo
