On Fri, May 31, 2019 at 2:55 AM Joe Perches <[email protected]> wrote: > > On Fri, 2019-05-31 at 01:51 +0200, Matteo Croce wrote: > > Commit 6a33853c5773 ("proc/sysctl: add shared variables for range check") > > adds some shared const variables to be used instead of a local copy in > > each source file. > > Warn when a chunk duplicates one of these values in a ctl_table struct: > [] > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > @@ -6639,6 +6639,13 @@ sub process { > > "unknown module license " . > > $extracted_string . "\n" . $herecurr); > > } > > } > > + > > +# check for sysctl duplicate constants > > + if ($line =~ > > /\.extra[12]\s*=\s*&(zero|one|int_max|max_int)\b/) { > > + my $extracted_string = get_quoted_string($line, > > $rawline); > > + WARN("DUPLICATED_SYSCTL_CONST", > > + "duplicated sysctl range checking value '$1', > > consider using the shared one in include/linux/sysctl.h" . > > $extracted_string . "\n" . $herecurr); > > + } > > why is $extracted_string used here? > >
Right, it's always empty. I'm sending a v2. Regards, -- Matteo Croce per aspera ad upstream
