> On 30/5/19 6:03, Hyungwoo Yang wrote: > > Kernel crashes during suspend due to wrong conversion in suspend and > > resume functions. > > > > Use the proper helper to get ishtp_cl_device instance. > > > > Signed-off-by: Hyungwoo Yang <[email protected]> > > --- > > drivers/platform/chrome/cros_ec_ishtp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/platform/chrome/cros_ec_ishtp.c > > b/drivers/platform/chrome/cros_ec_ishtp.c > > index e504d25..430731c 100644 > > --- a/drivers/platform/chrome/cros_ec_ishtp.c > > +++ b/drivers/platform/chrome/cros_ec_ishtp.c > > @@ -707,7 +707,7 @@ static int cros_ec_ishtp_reset(struct ishtp_cl_device > > *cl_device) > > */ > > static int __maybe_unused cros_ec_ishtp_suspend(struct device > > *device) { > > - struct ishtp_cl_device *cl_device = dev_get_drvdata(device); > > + struct ishtp_cl_device *cl_device = ishtp_dev_to_cl_device(device); > > struct ishtp_cl *cros_ish_cl = ishtp_get_drvdata(cl_device); > > struct ishtp_cl_data *client_data = > > ishtp_get_client_data(cros_ish_cl); > > > > @@ -722,7 +722,7 @@ static int __maybe_unused cros_ec_ishtp_suspend(struct > > device *device) > > */ > > static int __maybe_unused cros_ec_ishtp_resume(struct device *device) > > { > > - struct ishtp_cl_device *cl_device = dev_get_drvdata(device); > > + struct ishtp_cl_device *cl_device = ishtp_dev_to_cl_device(device); > > struct ishtp_cl *cros_ish_cl = ishtp_get_drvdata(cl_device); > > struct ishtp_cl_data *client_data = > ishtp_get_client_data(cros_ish_cl); > > > > > > As this patch is a fix for '26a14267aff2 platform/chrome: Add ChromeOS EC > ISHTP driver' which is still for-next material, do you mind if I squash both > patches? > > If you don't mind I'll add your Signed-off and a small comment saying that > you fixed this.
I don't mind. please do whatever you want. but it has dependency with https://patchwork.kernel.org/project/linux-input/list/?series=124780 > > Thanks, > Enric
