RE: [EXT] Re: [PATCH] mwifiex: check for null return from skb_copy

[Ganapathi Bhat]

Hi Dan,

> > > >         if (is_multicast_ether_addr(ra)) {
> > > >                 skb_uap = skb_copy(skb, GFP_ATOMIC);
> > > > +               if (!skb_uap)
> > > > +                       return -ENOMEM;
> > >
> > > I think we would want to free dev_kfree_skb_any(skb) before returning.
> > I think if the pointer is NULL, no need to free it;
> 
> You're misreading skb vs skb_uap.  "skb_uap" is NULL but "skb" is non-NULL
> and I'm pretty sure we should free it.

Oh, right. I missed it; Yes you are correct.

Regards,
Ganapathi