> -----Original Message-----
> From: Leonard Crestez
> Sent: Monday, June 3, 2019 4:45 PM
> To: Anson Huang <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Aisheng Dong
> <[email protected]>; Jacky Bai <[email protected]>; Abel Vesa
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]
> Cc: dl-linux-imx <[email protected]>
> Subject: Re: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver
> 
> On 6/3/2019 4:33 AM, [email protected] wrote:
> > From: Anson Huang <[email protected]>
> >
> > This patch adds i.MX8MN clock driver support.
> 
> > +#include "clk.h"
> > +
> > +#define PLL_1416X_RATE(_rate, _m, _p, _s)          \
> > +   {                                               \
> > +           .rate   =       (_rate),                \
> > +           .mdiv   =       (_m),                   \
> > +           .pdiv   =       (_p),                   \
> > +           .sdiv   =       (_s),                   \
> > +   }
> > +
> > +#define PLL_1443X_RATE(_rate, _m, _p, _s, _k)              \
> > +   {                                               \
> > +           .rate   =       (_rate),                \
> > +           .mdiv   =       (_m),                   \
> > +           .pdiv   =       (_p),                   \
> > +           .sdiv   =       (_s),                   \
> > +           .kdiv   =       (_k),                   \
> > +   }
> 
> These macros are shared with clk-imx8mm (and perhaps some future chips)
> so they should be moved to driver/clk/imx/clk.h

OK, will move them into clk.h in V3.

Anson.

Reply via email to