On Mon, Jun 03, 2019 at 02:42:12PM +0000, Rasmus Villemoes wrote: > diff --git a/drivers/net/dsa/mv88e6xxx/global1.h > b/drivers/net/dsa/mv88e6xxx/global1.h > index bb92a130cbef..2bcbe7c8b279 100644 > --- a/drivers/net/dsa/mv88e6xxx/global1.h > +++ b/drivers/net/dsa/mv88e6xxx/global1.h > @@ -279,6 +279,8 @@ int mv88e6390_g1_mgmt_rsvd2cpu(struct mv88e6xxx_chip > *chip); > int mv88e6085_g1_ip_pri_map(struct mv88e6xxx_chip *chip); > int mv88e6085_g1_ieee_pri_map(struct mv88e6xxx_chip *chip); > > +int mv88e6250_g1_ieee_pri_map(struct mv88e6xxx_chip *chip); > +
Hi Rasmus We are not 100% consistent, but we try to put all variants of a method together, and then put a blank line afterwards. So could you make this: int mv88e6085_g1_ip_pri_map(struct mv88e6xxx_chip *chip); int mv88e6085_g1_ieee_pri_map(struct mv88e6xxx_chip *chip); int mv88e6250_g1_ieee_pri_map(struct mv88e6xxx_chip *chip); int mv88e6185_g1_set_cascade_port(struct mv88e6xxx_chip *chip, int port); Reviewed-by: Andrew Lunn <[email protected]> Andrew
