Re: [PATCH v3 2/2] power: supply: ucs1002: Add HWMON interface

[Andrew F. Davis]

On 6/5/19 3:23 AM, Andrey Smirnov wrote:
Expose current sensors found on UCS1002 via HWMON.
Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com>
Reviewed-by: Guenter Roeck <li...@roeck-us.net>
Cc: Chris Healy <cphe...@gmail.com>
Cc: Cory Tusar <cory.tu...@zii.aero>
Cc: Lucas Stach <l.st...@pengutronix.de>
Cc: Fabio Estevam <fabio.este...@nxp.com>
Cc: Guenter Roeck <li...@roeck-us.net>
Cc: Sebastian Reichel <s...@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux...@vger.kernel.org
---
  drivers/power/supply/ucs1002_power.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/drivers/power/supply/ucs1002_power.c 
b/drivers/power/supply/ucs1002_power.c
index 677f20a4d76f..a4b6b37549cf 100644
--- a/drivers/power/supply/ucs1002_power.c
+++ b/drivers/power/supply/ucs1002_power.c
@@ -571,6 +571,12 @@ static int ucs1002_probe(struct i2c_client *client,
                return ret;
        }
  
+	ret = devm_power_supply_add_hwmon_sysfs(info->charger);

Could this be added to the core power supply framework on registering so 
all devices get this, vs each driver having to add this line?

Andrew

+       if (ret) {
+               dev_err(dev, "Failed to add hmwon attributes: %d\n", ret);
+               return ret;
+       }
+
        ret = regmap_read(info->regmap, UCS1002_REG_PIN_STATUS, &regval);
        if (ret) {
                dev_err(dev, "Failed to read pin status: %d\n", ret);