On Tue, Jun 11, 2019 at 08:17:00PM +0200, Greg Kroah-Hartman wrote: > The csr_file variable was only ever set, never read. So remove it from > struct idt_89hpesx_dev as it is pointless to keep around. > > Cc: Arnd Bergmann <[email protected]> > Cc: Dan Carpenter <[email protected]> > Cc: Kees Cook <[email protected]> > Cc: Colin Ian King <[email protected]> > Cc: [email protected] > Signed-off-by: Greg Kroah-Hartman <[email protected]>
Reviewed-by: Kees Cook <[email protected]> -Kees > --- > drivers/misc/eeprom/idt_89hpesx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/misc/eeprom/idt_89hpesx.c > b/drivers/misc/eeprom/idt_89hpesx.c > index 8a4659518c33..81c70e5bc168 100644 > --- a/drivers/misc/eeprom/idt_89hpesx.c > +++ b/drivers/misc/eeprom/idt_89hpesx.c > @@ -115,7 +115,6 @@ static struct dentry *csr_dbgdir; > * @client: i2c client used to perform IO operations > * > * @ee_file: EEPROM read/write sysfs-file > - * @csr_file: CSR read/write debugfs-node > */ > struct idt_smb_seq; > struct idt_89hpesx_dev { > @@ -137,7 +136,6 @@ struct idt_89hpesx_dev { > > struct bin_attribute *ee_file; > struct dentry *csr_dir; > - struct dentry *csr_file; > }; > > /* > @@ -1378,8 +1376,8 @@ static void idt_create_dbgfs_files(struct > idt_89hpesx_dev *pdev) > pdev->csr_dir = debugfs_create_dir(fname, csr_dbgdir); > > /* Create Debugfs file for CSR read/write operations */ > - pdev->csr_file = debugfs_create_file(cli->name, 0600, > - pdev->csr_dir, pdev, &csr_dbgfs_ops); > + debugfs_create_file(cli->name, 0600, pdev->csr_dir, pdev, > + &csr_dbgfs_ops); > } > > /* > -- > 2.22.0 > -- Kees Cook
